Skip to content

Graphormer fix #21699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sgugger merged 6 commits into from
Feb 24, 2023
Merged

Graphormer fix #21699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0e353a4
Removed useless check for backend
clefourrier Feb 20, 2023
be3bf79
fix style check for graphormer
clefourrier Feb 20, 2023
9ff102e
Merge branch 'huggingface:main' into fix-graphormer
clefourrier Feb 22, 2023
3d461e4
Reverted change and corrected requires_backend for cython
clefourrier Feb 22, 2023
efb559e
code qual
clefourrier Feb 22, 2023
d70f8d0
Merge branch 'huggingface:main' into fix-graphormer
clefourrier Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/transformers/models/graphormer/collating_graphormer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@ def convert_to_single_emb(x, offset: int = 512):


def preprocess_item(item, keep_features=True):
requires_backends(preprocess_item, ["Cython"])
Comment thread
clefourrier marked this conversation as resolved.
if not is_cython_available():
raise ImportError("Graphormer preprocessing needs Cython (pyximport)")
requires_backends(preprocess_item, ["cython"])

if keep_features and "edge_attr" in item.keys(): # edge_attr
edge_attr = np.asarray(item["edge_attr"], dtype=np.int64)
Expand Down
6 changes: 6 additions & 0 deletions src/transformers/utils/import_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,6 +992,11 @@ def is_cython_available():
decord`. Please note that you may need to restart your runtime after installation.
"""

CYTHON_IMPORT_ERROR = """
{0} requires the Cython library but it was not found in your environment. You can install it with pip: `pip install
Cython`. Please note that you may need to restart your runtime after installation.
"""

BACKENDS_MAPPING = OrderedDict(
[
("bs4", (is_bs4_available, BS4_IMPORT_ERROR)),
Expand Down Expand Up @@ -1023,6 +1028,7 @@ def is_cython_available():
("accelerate", (is_accelerate_available, ACCELERATE_IMPORT_ERROR)),
("oneccl_bind_pt", (is_ccl_available, CCL_IMPORT_ERROR)),
("decord", (is_decord_available, DECORD_IMPORT_ERROR)),
("cython", (is_cython_available, CYTHON_IMPORT_ERROR)),
]
)

Expand Down