Generate: make TF .generate() signature == PT .generate() signature
#21525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
gante
changed the title
.generate() signature == PT .generate() signature
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
TF generation test addition PR 3 (out of ???).
In an effort to move generation integration tests to be framework-agnostic, I'll be adding low-hanging fruit to TF. This PR adds framework-agnostic tests for the signature of
.generate(), which means that the TF signature had to be updated 🙃Please note that this change is backward compatible -- regardless of whether the user was passing
.generate(input_ids),.generate(input_ids=input_ids), or (e.g.).generate(pixel_values=pixel_values), no change on their end is needed.