[CLAP] Add CLAP to the library #21370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `CLAPVision` to `CLAPAudio` - refactor kwargs of audio modules
sanchit-gandhi
approved these changes
Feb 15, 2023
Contributor
sanchit-gandhi
left a comment
sanchit-gandhi
left a comment
There was a problem hiding this comment.
Super nice PR! Thanks @ArthurZucker and @younesbelkada for your work here!
ArthurZucker
commented
Feb 15, 2023
ArthurZucker
commented
Feb 15, 2023
Collaborator
Author
|
Found a few discrepancies with the various variables in the config that are not used. Will finish asap should makes things clearer. |
ArthurZucker
commented
Feb 16, 2023
Collaborator
Author
|
Ok I broke the history |
ArthurZucker
force-pushed
the
add-clap-model
branch
from
e69b04f to
66b7dfe
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds CLAP to the HF library cc @younesbelkada