-
Notifications
You must be signed in to change notification settings - Fork 31.9k
[Whisper] Add SpecAugment #21298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ArthurZucker
merged 13 commits into
huggingface:main
from
bofenghuang:add-specaugment-to-whisper-modeling
Feb 24, 2023
Merged
[Whisper] Add SpecAugment #21298
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
68b02e0
Return and rescale attention_mask
bofenghuang 95bd0ea
Add SpecAugment to Whisper modeling
bofenghuang 380d7c9
Fix test
bofenghuang a803659
Update docstring
bofenghuang 87740aa
Add SpecAug related parameters to model config
bofenghuang d5a0d10
Add the _mask_input_features function to doc
bofenghuang 74c7bbd
Fix quality
bofenghuang 2cd09d8
Apply suggestions from code review
bofenghuang e58cd7a
Remove dev comments
bofenghuang 018fed0
Add test
bofenghuang fdbaa94
Resolve conflict
bofenghuang d843448
feat: mask {feature, time} prob fast tests
934d13a
Apply suggestions from code review
bofenghuang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at this point, the input features were converted potentially from a
torch.tensorto numpy no? Also if it what on GPU,attention_mask.sum(-1).detach().tolist()will need the.cpu()call.Handling devices is gonna be a hassle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function just generates a random NumPy mask, which will then be converted to tensor and mask the input features.
For
attention_mask.sum(-1).detach().tolist(), not sure if it's a good practice, buttolist()automatically moves tensors to CPU if necessaryThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think it's fine to do this (copied from W2V2)