Fix TrainingArguments.label_names docs to reflect the correct default value behaviour
#21288
Conversation
sgugger
left a comment
sgugger
left a comment
There was a problem hiding this comment.
Thanks for adding this! Left a suggestion and make sure to run make style on your branch so that the quality checks pass.
src/transformers/training_args.py
Outdated
| Will eventually default to `["labels"]` except if the model used is one of the `XxxForQuestionAnswering` in | ||
| which case it will default to `["start_positions", "end_positions"]`. | ||
| Will eventually default to the list of input keys that contain the word "label", except if the model used is |
There was a problem hiding this comment.
| Will eventually default to the list of input keys that contain the word "label", except if the model used is | |
| Will eventually default to the list of arguments names in `model.forward` that contain the word "label", except if the model used is |
There was a problem hiding this comment.
In that case, should I mention TF and Flax models that use call and __call__ methods instead of forward? Or is this more for internal usage?
There was a problem hiding this comment.
Maybe "argument names accepted by the model" then, to be framework-agnostic.
|
The documentation is not available anymore as the PR was closed or merged. |
|
This was never flagged as a breaking change (indeed I only found this because it broke one of my scripts). I wonder if I should add "🚨 🚨 🚨" to the PR name to indicate a breaking change |
|
The breaking change is in the PR that changed the default to |
4 participants
Fixes #21287
@sgugger