Skip to content

Conversation

@MKhalusova
Copy link
Contributor

The docstring of the transformers.pipeline listed only 16 supported tasks while SUPPORTED_TASKS contains 24 tasks. This PR adds the missing tasks to the docstrings so that the generated reference docs accurately list all of the supported tasks here - https://huggingface.co/docs/transformers/main/en/main_classes/pipelines#transformers.pipeline

@MKhalusova MKhalusova requested a review from sgugger January 23, 2023 18:30
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jan 23, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on that!

Comment on lines 447 to 451
- `"visual-question-answering"`
- `"document-question-answering"`
- `"object-detection"`
- `"depth-estimation"`
- `"video-classification"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be goo to have those alphabetically sorted, like the rest.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will do!

Comment on lines 531 to 535
- `"visual-question-answering"`: will return a [`VisualQuestionAnsweringPipeline`].
- `"document-question-answering"`: will return a [`DocumentQuestionAnsweringPipeline`].
- `"object-detection"`: will return a [`ObjectDetectionPipeline`].
- `"depth-estimation"`: will return a [`DepthEstimationPipeline`].
- `"video-classification"`: will return a [`VideoClassificationPipeline`].
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@MKhalusova MKhalusova merged commit 9e86c4e into huggingface:main Jan 23, 2023
@MKhalusova MKhalusova deleted the supported-pipeline-tasks-update branch January 25, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants