[Whisper] fix all issues with unk token #21250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Jan 23, 2023
Collaborator
sgugger
left a comment
sgugger
left a comment
There was a problem hiding this comment.
Thanks for the fix! Make sure to run make style on your branch to fix the quality issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously, all OOV ( and thus timestamp tokens) outputed by the model are decoded to
<|endoftext|>by thexxx.enwhisper models. This does not happen with the multilingual model only because I added""to the vocabulary, and theunk_token_idis the same"". But this does not really make sense.As the default behavior for Whisper is just to outptu
""for any OOV, now the_convert_id_to_tokenfunction does not use aunk_token.This will fix the inconsistency, and will help for the whisper refactoring.