-
Notifications
You must be signed in to change notification settings - Fork 31.9k
Add WhisperTokenizerFast #21222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ArthurZucker
merged 20 commits into
huggingface:main
from
jonatanklosko:jk-whisper-fast-tokenizer
Feb 21, 2023
Merged
Add WhisperTokenizerFast #21222
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
94b9156
Add WhisperTokenizerFast
jonatanklosko 40f0389
Fixup
jonatanklosko c13e76a
Up
jonatanklosko ff79f1f
Up
jonatanklosko ba24f21
Improve tests
jonatanklosko b6303bb
Update src/transformers/models/whisper/tokenization_whisper_fast.py
jonatanklosko 53cbd1b
Merge branch 'main' into jk-whisper-fast-tokenizer
jonatanklosko db9676d
Keep stride in whisper pipelien test
jonatanklosko 4bebb2c
Remove unknown token special case
jonatanklosko 2c4d0f4
Reduce vocabulary size in tests
jonatanklosko d012b3c
Merge branch 'main' into jk-whisper-fast-tokenizer
jonatanklosko 0eca3ec
Fix vocab size assertion
jonatanklosko 7591356
Merge branch 'main' into jk-whisper-fast-tokenizer
jonatanklosko 21f69cf
Sync copied changes from WhisperTokenizer
jonatanklosko 4e636bf
Skip pipeline tests
jonatanklosko 63ac687
Update assertion
jonatanklosko 487a7ac
Remove Whisper tokenizer dependency on sentencepiece
jonatanklosko 9d861a1
Merge branch 'main' into jk-whisper-fast-tokenizer
jonatanklosko 3863b69
Merge branch 'main' into jk-whisper-fast-tokenizer
jonatanklosko 9311ab0
Format
jonatanklosko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure there's a reason why this is modified?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this comment is a leftover from copying the FunnelConverter, because note that the template doesn't have
:2token type id anywhere, which is the case here:transformers/src/transformers/convert_slow_tokenizer.py
Line 189 in b6303bb
(I just noticed that when adding the WhisperConverter based on the GPT2 one)