[BLIP] fix doctest
#21217
Merged
[BLIP] fix doctest
#21217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
ydshieh
approved these changes
Jan 20, 2023
Collaborator
ydshieh
left a comment
ydshieh
left a comment
There was a problem hiding this comment.
LGTM 💯 with -1 --> I want to have ♾️ cats instead of just 2 😹
| "Either `decoder_input_ids` or `labels` should be passed when calling `forward` with" | ||
| " `BlipForQuestionAnswering`. if you are training the model make sure that `labels` is passed, if you" | ||
| " are using the model for inference make sure that `decoder_input_ids` is passed." | ||
| " are using the model for inference make sure that `decoder_input_ids` is passed or call `generate`" |
Collaborator
There was a problem hiding this comment.
No for the change in this PR, but if you are training should be If you are training. And the second part should be , and if you ... or . If you ...
Collaborator
There was a problem hiding this comment.
Let @NielsRogge for a second eye 👀 on this PR.
NielsRogge
reviewed
Jan 23, 2023
Co-authored-by: NielsRogge <48327001+NielsRogge@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes
BLIPdoctest.Link to failing job: https://github.com/huggingface/transformers/actions/runs/3964164193
The docstring of the
forwardmethod ofBlipForQuestionAnsweringhas been corrected to educate users on how to correctly use this module after #21021 being merged.The logic now of the
forwardmethod is pretty much similar toT5.cc @ydshieh 💯