Skip to content

Conversation

@amyeroberts
Copy link
Contributor

@amyeroberts amyeroberts commented Jan 19, 2023

What does this PR do?

Adds properties with deprecations warnings to image processors for backwards compatibility. This resolves issues users had when trying to reference a deprecated property e.g. image_processor.reduce_labels.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jan 19, 2023

The documentation is not available anymore as the PR was closed or merged.

@amyeroberts amyeroberts force-pushed the backwards-compatibility-ip-properties branch 2 times, most recently from 603e620 to 1b4ecaa Compare January 23, 2023 17:24
@amyeroberts amyeroberts force-pushed the backwards-compatibility-ip-properties branch from 1b4ecaa to f45ac57 Compare January 23, 2023 17:30
@amyeroberts amyeroberts marked this pull request as ready for review January 23, 2023 18:07
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@amyeroberts amyeroberts merged commit c18b4fb into huggingface:main Jan 23, 2023
@amyeroberts amyeroberts deleted the backwards-compatibility-ip-properties branch January 23, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants