Skip to content

Conversation

@amyeroberts
Copy link
Contributor

@amyeroberts amyeroberts commented Jan 17, 2023

What does this PR do?

Updates all of the feature extractor references to image processors in the examples folder.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jan 17, 2023

The documentation is not available anymore as the PR was closed or merged.

@amyeroberts amyeroberts changed the title Update example image processors Update examples with image processors Jan 18, 2023
@amyeroberts amyeroberts force-pushed the update-example-image-processors branch from 0709fad to b5c2839 Compare January 19, 2023 14:37
@amyeroberts amyeroberts marked this pull request as ready for review January 19, 2023 15:09
Copy link
Contributor

@NielsRogge NielsRogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing! 🙏

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@amyeroberts amyeroberts merged commit 4bc18e7 into huggingface:main Jan 19, 2023
@amyeroberts amyeroberts deleted the update-example-image-processors branch January 19, 2023 15:15
@stas00
Copy link
Contributor

stas00 commented Jan 24, 2023

This broke the deepspeed tests. Fix is here: #21283

when modifying examples and breaking back compat please scan the slow tests and adjust those too. Thank you!

The reason this is important is because Deepspeed CI runs our slow deepspeed tests as normal CI so when we break things their CI is broken.

@amyeroberts
Copy link
Contributor Author

@stas00 - thanks for applying a quick fix and apologies about the break. I'll make sure to remember the slow tests next time!

@stas00
Copy link
Contributor

stas00 commented Jan 24, 2023

Thank you, Amy!

tests/extended/ and tests/deepspeed are the ones that heavily rely on examples/pytorch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants