Skip to content

Conversation

@amyeroberts
Copy link
Contributor

What does this PR do?

Replaces references of feature extractors with image processors that had been missed in the first batch of changes

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jan 13, 2023

The documentation is not available anymore as the PR was closed or merged.

@amyeroberts amyeroberts force-pushed the fix-doc-examples-image-processor branch from bca972c to ea28fb3 Compare January 16, 2023 11:14
@amyeroberts amyeroberts changed the title Update docs examples FE -> IP Update modeling docs examples FE -> IP Jan 16, 2023
@amyeroberts amyeroberts marked this pull request as ready for review January 16, 2023 16:12
@amyeroberts amyeroberts changed the title Update modeling docs examples FE -> IP Update modeling doc strings FE -> IP Jan 19, 2023
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that add_code_sample_docstrings now ignores the processor_class argument, so you can just remove it entirely in all those model files. Left pointers on the first ones and then got tired of saying "Same here" ;-)

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work on this!

Copy link
Contributor

@NielsRogge NielsRogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@amyeroberts amyeroberts merged commit 91c2278 into huggingface:main Jan 20, 2023
@amyeroberts amyeroberts deleted the fix-doc-examples-image-processor branch January 20, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants