Skip to content

Conversation

@yingzha
Copy link
Contributor

@yingzha yingzha commented Jan 9, 2023

What does this PR do?

Fixes missing imports in CLIPConfig docstring.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jan 9, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Pinging @sgugger for a final look :)

Not sure what's happening with the failing circleci check. Could you try refreshing your permissions as shown here?

@sgugger
Copy link
Collaborator

sgugger commented Jan 10, 2023

Yes, you will need to refresh your circleCI permissions and push an empty commit so we can check the tests are passing.

@yingzha yingzha force-pushed the update-clip-config-doc branch from 469a654 to 63224dd Compare January 10, 2023 19:10
@yingzha yingzha force-pushed the update-clip-config-doc branch from 63224dd to d2ab403 Compare January 10, 2023 19:12
@yingzha
Copy link
Contributor Author

yingzha commented Jan 10, 2023

@sgugger Done.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@sgugger sgugger merged commit 64b6b2b into huggingface:main Jan 11, 2023
@yingzha yingzha deleted the update-clip-config-doc branch January 11, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants