Skip to content

Conversation

@parambharat
Copy link
Contributor

What does this PR do?

The PR updates the WandbCallback with the following changes:

  • Adds on_save method to upload model checkpoints as artifacts.
  • Changes the default value of environment variable WANDB_WATCH from gradients to false. This enables quicker training when defaults are used. The user can easily change this behavior by setting the env variable.
  • Changes the WANDB_LOG_MODEL variable from bool to str allowing for different settings to upload artifacts.
  • Modifies the class dostring to reflect the above changes.
  • Fixes broken link to wandb documentation
  • Changes the wandb run_name from output_dir to wandb auto generated name. this avoids duplication of run names in wandb workspace

Before submitting

Who can review?

Examples

  • Example colab reflecting all the changes to the WandbCallback
  • Example Weights & Biases workspace with runs that show different settings.
  • Example Weights & Biases Artifact created for checkpoints

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jan 6, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! I left a couple of comments.

@parambharat
Copy link
Contributor Author

Hey, @sgugger : Thanks for the quick review and suggestions. I've resolved all the issues. 🤗

@sgugger
Copy link
Collaborator

sgugger commented Jan 8, 2023

@parambharat There is a weird issue with the tests. Could you try refreshing your permissions as shown here and then pushing an empty commit?

@parambharat
Copy link
Contributor Author

Hey, @sgugger. I ran the fix that you suggested and all checks pass now.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating! I left two suggestions on formatting :)

@parambharat
Copy link
Contributor Author

parambharat commented Jan 10, 2023

Thank you @stevhliu. I've committed your recommendations.

@sgugger sgugger merged commit 07cde58 into huggingface:main Jan 10, 2023
@sgugger
Copy link
Collaborator

sgugger commented Jan 10, 2023

Thanks again for your contribution!

@parambharat parambharat deleted the feature/wandb-callback-update branch January 10, 2024 11:00
@qubvel qubvel mentioned this pull request Apr 24, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants