-
Notifications
You must be signed in to change notification settings - Fork 31.6k
feature: update wandb callback to upload checkpoints #21035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: update wandb callback to upload checkpoints #21035
Conversation
- removes duplicated run names from wandb workspace - models can be logged with corresponding run names
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! I left a couple of comments.
|
Hey, @sgugger : Thanks for the quick review and suggestions. I've resolved all the issues. 🤗 |
|
@parambharat There is a weird issue with the tests. Could you try refreshing your permissions as shown here and then pushing an empty commit? |
|
Hey, @sgugger. I ran the fix that you suggested and all checks pass now. |
stevhliu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating! I left two suggestions on formatting :)
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
|
Thank you @stevhliu. I've committed your recommendations. |
|
Thanks again for your contribution! |
What does this PR do?
The PR updates the
WandbCallbackwith the following changes:on_savemethod to upload model checkpoints as artifacts.WANDB_WATCHfromgradientstofalse. This enables quicker training when defaults are used. The user can easily change this behavior by setting the env variable.WANDB_LOG_MODELvariable frombooltostrallowing for different settings to upload artifacts.run_namefromoutput_dirto wandb auto generated name. this avoids duplication of run names in wandb workspaceBefore submitting
Pull Request section?
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Examples