Skip to content

Conversation

@Observer46
Copy link
Contributor

What does this PR do?

I used the script for training Seq2seq QA and realized that --do_predict contains a bug - kwarg outputs should be an instance of class EvalLoopOutput, but NumPy array is passed instead. Together with extracting predictions in the body of the method post_processing_function (line 610 in run_seq2seq_qa.py) this results in an error every time you try to run tests with this script.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@karthikrangasai @sgugger

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jan 5, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@sgugger sgugger merged commit ff8dcb5 into huggingface:main Jan 6, 2023
silverriver pushed a commit to silverriver/transformers that referenced this pull request Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants