[CLIPSeg] Fix integration test #20995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
ydshieh
approved these changes
Jan 4, 2023
Collaborator
There was a problem hiding this comment.
Thanks for the fix. LGTM, but I am wondering one thing: ClipSeg has (only) CLIPSegProcessor which include ViTImageProcessor, which itself has default values IMAGENET_STANDARD_MEAN and IMAGENET_STANDARD_STD.
So the image processor used for ClipSeg is just ViTImageProcessor with different settings?
Contributor
Author
|
Yes, it uses |
silverriver
pushed a commit
to silverriver/transformers
that referenced
this pull request
Jan 6, 2023
Fix integration test Co-authored-by: Niels Rogge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A user reported at timojl/clipseg#18 that CLIPSeg uses the ImageNet mean + std instead of the [-1, 1] range for normalization. This PR updates the integration test as repos on the hub were fixed.