-
Notifications
You must be signed in to change notification settings - Fork 31.6k
Support turning off the model uploading in ClearML #20969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support turning off the model uploading in ClearML #20969
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! Could you just make sure to document this new env variable in the docstring of the callback (along the other ones)?
|
Hi @sgugger :) I modified the docstring, as you suggested. Can you please have a look? 🙏 |
|
Code looks good but it seems there is an issue with your CircleCI permissions, the tests won't run. |
# Conflicts: # src/transformers/integrations.py
|
@sgugger I re-authenticated to CircleCI, and it seems that the CI passed :) |
sgugger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Just one last comment and we should be good to merge.
Co-authored-by: Sylvain Gugger <[email protected]>
|
@sgugger Thanks for the feedback. I accepted your change :) |
|
Thanks for your contribution! |
* Add support for turning off the model uploading in ClearML * Add documentation for the CLEARML_LOG_MODEL environment variable * Adjust new doc addition to the new style Co-authored-by: Sylvain Gugger <[email protected]> Co-authored-by: Dudu Lasry <[email protected]> Co-authored-by: Sylvain Gugger <[email protected]>
What does this PR do?
Support turning off the model uploading in ClearML using an environment variable called
CLEARML_LOG_MODELFixes #20889
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.