Skip to content

Conversation

@Bearnardd
Copy link
Contributor

What does this PR do?

Fixes conversion file convert_levit_timm_to_pytorch.py for levit

Fixes # (issue)
#20937

Who can review?

@NielsRogge

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 29, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link

@CloudInnovator CloudInnovator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes follow convention and all tests passed.

action="store_false",
help="Do not push model and feature extractor to the hub",
)
parser.set_defaults(push_to_hub=True)
Copy link
Contributor

@NielsRogge NielsRogge Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) I'm not using this line in any conversion script

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NielsRogge removed.

Copy link
Contributor

@NielsRogge NielsRogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@sgugger sgugger merged commit f93c90d into huggingface:main Jan 6, 2023
@sgugger
Copy link
Collaborator

sgugger commented Jan 6, 2023

Thanks again for your contribution!

silverriver pushed a commit to silverriver/transformers that referenced this pull request Jan 6, 2023
* fix levit timm conversion file

* remove set_defaults
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants