[Past CI] 🔥 Leave Past CI failures in the past 🔥 #20861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
ydshieh
changed the title
ydshieh
commented
Dec 21, 2022
| candidate_score = candidate_score.view(-1, self.config.num_candidates, self.config.retriever_proj_size) | ||
| # [batch_size, num_candidates] | ||
| relevance_score = torch.einsum("BD,BND->BN", query_score, candidate_score) | ||
| relevance_score = torch.einsum("bd,bnd->bn", query_score, candidate_score) |
Collaborator
Author
There was a problem hiding this comment.
torch 1.8 complains uppercase here
ydshieh
commented
Dec 21, 2022
| # move channels to last dimension, as the _build_network_inputs method below expects this | ||
| if inputs.ndim == 4: | ||
| inputs = torch.permute(inputs, (0, 2, 3, 1)) | ||
| inputs = inputs.permute(0, 2, 3, 1) |
Collaborator
Author
There was a problem hiding this comment.
torch 1.8 has no torch.permute, but x.permute works
|
The documentation is not available anymore as the PR was closed or merged. |
ydshieh
requested review from
LysandreJik and
sgugger
and removed request for
sgugger
sgugger
approved these changes
Dec 22, 2022
Collaborator
sgugger
left a comment
sgugger
left a comment
There was a problem hiding this comment.
Thanks for all the fixes!
LysandreJik
approved these changes
Dec 22, 2022
Member
LysandreJik
left a comment
LysandreJik
left a comment
There was a problem hiding this comment.
Fantastic @ydshieh, thank you for your work!
MKhalusova
pushed a commit
to MKhalusova/transformers
that referenced
this pull request
Dec 28, 2022
* torch.jit._state * Fix past CI * Fix for perceiver * Fix REALM * Fix for Bloom * Fix for SwinMode * Fix for TrajectoryTransformerModel * Fix for test_wav2vec2_with_lm * make style Co-authored-by: ydshieh <[email protected]>
Merged
silverriver
pushed a commit
to silverriver/transformers
that referenced
this pull request
Jan 6, 2023
* torch.jit._state * Fix past CI * Fix for perceiver * Fix REALM * Fix for Bloom * Fix for SwinMode * Fix for TrajectoryTransformerModel * Fix for test_wav2vec2_with_lm * make style Co-authored-by: ydshieh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make Past CI (with
torch 1.8) cleaner