Skip to content

Conversation

@amyeroberts
Copy link
Contributor

@amyeroberts amyeroberts commented Dec 14, 2022

What does this PR do?

Replaces all feature extractor references with image processor references in the test_image_processing_xxx.py files
* feature_extractor = XxxFeatureExtractor() -> image_processor = XxxImageProcessor

Requires #20785 in order to replace FeatureExtractionSavingTestMixin

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

@amyeroberts amyeroberts force-pushed the rename-fe-to-ip-tests branch from 7ee2516 to c0ce1b5 Compare December 14, 2022 15:33
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 14, 2022

The documentation is not available anymore as the PR was closed or merged.

@amyeroberts amyeroberts changed the title Rename fe to ip tests Rename vision feature extractor tests to image processor Dec 15, 2022
@amyeroberts amyeroberts force-pushed the rename-fe-to-ip-tests branch 2 times, most recently from fdf0bc0 to 0c8ff98 Compare January 17, 2023 18:14
@amyeroberts amyeroberts changed the title Rename vision feature extractor tests to image processor Update tests: replace feature extractor tests with image processor Jan 17, 2023
@amyeroberts amyeroberts force-pushed the rename-fe-to-ip-tests branch 2 times, most recently from c7addfa to 0d5b311 Compare January 20, 2023 17:06
@amyeroberts amyeroberts force-pushed the rename-fe-to-ip-tests branch from 8f8f911 to 73aa8a2 Compare January 23, 2023 14:13
@amyeroberts amyeroberts marked this pull request as ready for review January 23, 2023 16:41
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 * 2

@amyeroberts amyeroberts merged commit e2bd7f8 into huggingface:main Jan 23, 2023
@amyeroberts amyeroberts deleted the rename-fe-to-ip-tests branch January 23, 2023 17:25
This was referenced Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants