-
Notifications
You must be signed in to change notification settings - Fork 31.9k
Update tests: replace feature extractor tests with image processor #20768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
amyeroberts
merged 15 commits into
huggingface:main
from
amyeroberts:rename-fe-to-ip-tests
Jan 23, 2023
Merged
Update tests: replace feature extractor tests with image processor #20768
amyeroberts
merged 15 commits into
huggingface:main
from
amyeroberts:rename-fe-to-ip-tests
Jan 23, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ee2516 to
c0ce1b5
Compare
|
The documentation is not available anymore as the PR was closed or merged. |
fdf0bc0 to
0c8ff98
Compare
c7addfa to
0d5b311
Compare
5 tasks
…ace#20952) * Add generate kwargs to AutomaticSpeechRecognitionPipeline * Add test for generation kwargs
…e#20866) * Update parameters if creating with kwargs * Shallow copy to prevent mutating input * Pass all args in constructor dict - warnings in init * Fix typo
8f8f911 to
73aa8a2
Compare
sgugger
approved these changes
Jan 23, 2023
ydshieh
approved these changes
Jan 23, 2023
Collaborator
ydshieh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 * 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces all feature extractor references with image processor references in the
test_image_processing_xxx.pyfiles*
feature_extractor = XxxFeatureExtractor()->image_processor = XxxImageProcessorRequires #20785 in order to replace
FeatureExtractionSavingTestMixinBefore submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.