Skip to content

Fix AdamWeightDecay for TF 2.11 #20735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rocketknight1 merged 3 commits into from
Dec 13, 2022
Merged

Fix AdamWeightDecay for TF 2.11 #20735

Rocketknight1 merged 3 commits into from
Dec 13, 2022

Conversation

@Rocketknight1
Copy link
Member

@Rocketknight1 Rocketknight1 commented Dec 12, 2022 •
edited
Loading

Fixes #20724

@Rocketknight1 Rocketknight1 changed the title Fix AdamWeightDecay for TF Fix AdamWeightDecay for TF 2.11 Dec 12, 2022
@Rocketknight1
Copy link
Member Author

Rocketknight1 commented Dec 12, 2022

@gante take a quick look at this one too, please! Our AdamWeightDecay doesn't work with the new Optimizer base class in TF 2.11, so I moved it onto the legacy class for now. When I have more time I should clean this up properly, and possibly just use the official AdamW instead.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 12, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@Rocketknight1 Rocketknight1 merged commit 4f1788b into main Dec 13, 2022
@Rocketknight1 Rocketknight1 deleted the fix_adamweightdecay branch December 13, 2022 12:51
mpierrau pushed a commit to mpierrau/transformers that referenced this pull request Dec 15, 2022
@Rocketknight1
Fix AdamWeightDecay for TF 2.11 (huggingface#20735)
edecaeb 
* Fix AdamWeightDecay for TF

* Fix AdamWeightDecay for TF

* make fixup
@Rocketknight1 Rocketknight1 mentioned this pull request Dec 20, 2022
Closed
4 tasks
@el-profesor-04
Copy link

el-profesor-04 commented Jan 14, 2023

The same issue occurred with the Summarization tutorial. https://huggingface.co/course/chapter7/5?fw=tf#models-for-text-summarization

@Rocketknight1
Copy link
Member Author

Rocketknight1 commented Jan 19, 2023

Thanks @el-profesor-04 - can you confirm that the issue goes away with you install the latest version of transformers from main with pip install --upgrade git+https://github.com/huggingface/transformers.git?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gante gante Awaiting requested review from gante

1 more reviewer

@sgugger sgugger sgugger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tutorial on token classification throws casting error in Tensorflow 2.11

5 participants

@Rocketknight1 @HuggingFaceDocBuilderDev @el-profesor-04 @sgugger