Skip to content

Conversation

@Narsil
Copy link
Contributor

@Narsil Narsil commented Dec 12, 2022

What does this PR do?

Adding ValueError when imcompatible parameters are used.
#20662 (review)

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Narsil Narsil changed the title Adding ValueError when imcompatible parameters are used. Adding ValueError when incompatible parameters are used. Dec 12, 2022
@Narsil Narsil merged commit 53357e8 into huggingface:main Dec 12, 2022
@Narsil Narsil deleted the error_text_gen_options branch December 13, 2022 09:09
@PanQiWei
Copy link

@Narsil for what I read in #20662 , it seems what actually should imcompatible may return_text and return_tensors instead of return_text and return_full_text?

@Narsil
Copy link
Contributor Author

Narsil commented Dec 14, 2022

Oh, them too, will create a new PR. But return_text and return_full_text are also exclusive I think.

@Narsil Narsil mentioned this pull request Dec 14, 2022
5 tasks
mpierrau pushed a commit to mpierrau/transformers that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants