Skip to content

Conversation

@amyeroberts
Copy link
Contributor

@amyeroberts amyeroberts commented Dec 9, 2022

What does this PR do?

Removes functions in the image_transforms library from src/transformers/_init__.py.

The functionality this module provides are utils for processing images and are not the primary goal of the library.

Address an issue raised in #20627 - which highlighted some functions were in the init and others weren't.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 9, 2022

The documentation is not available anymore as the PR was closed or merged.

@amyeroberts amyeroberts force-pushed the remove-image-transforms-from-init branch from 9d5c04f to 235f7d0 Compare December 12, 2022 17:52
@amyeroberts amyeroberts marked this pull request as ready for review December 12, 2022 18:44
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 💯

@amyeroberts amyeroberts merged commit 9bafedc into huggingface:main Dec 14, 2022
@amyeroberts amyeroberts deleted the remove-image-transforms-from-init branch December 14, 2022 14:30
mpierrau pushed a commit to mpierrau/transformers that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants