Skip to content

Fix gpt2 fp16 training when tracing is enabled #20656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sgugger merged 3 commits into from
Dec 8, 2022
Merged

Fix gpt2 fp16 training when tracing is enabled #20656

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d950a8
ONNX tracing fix
JingyaHuang Dec 7, 2022
9d9b874
Merge branch 'huggingface:main' into fix-gpt2-onnx-fp16
JingyaHuang Dec 7, 2022
2e093fa
Remove conditional
JingyaHuang Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/transformers/models/decision_transformer/modeling_decision_transformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,10 @@ def _attn(self, query, key, value, attention_mask=None, head_mask=None):
# Need to be a tensor, otherwise we get error: `RuntimeError: expected scalar type float but found double`.
# Need to be on the same device, otherwise `RuntimeError: ..., x and y to be on the same device`
mask_value = torch.full([], mask_value, dtype=attn_weights.dtype).to(attn_weights.device)
attn_weights = torch.where(causal_mask, attn_weights, mask_value)
if torch.onnx.is_in_onnx_export():
attn_weights = torch.where(causal_mask, attn_weights.to(attn_weights.dtype), mask_value)
else:
attn_weights = torch.where(causal_mask, attn_weights, mask_value)

if attention_mask is not None:
# Apply the attention mask
Expand Down
5 changes: 4 additions & 1 deletion src/transformers/models/gpt2/modeling_gpt2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,10 @@ def _attn(self, query, key, value, attention_mask=None, head_mask=None):
# Need to be a tensor, otherwise we get error: `RuntimeError: expected scalar type float but found double`.
# Need to be on the same device, otherwise `RuntimeError: ..., x and y to be on the same device`
mask_value = torch.full([], mask_value, dtype=attn_weights.dtype).to(attn_weights.device)
attn_weights = torch.where(causal_mask, attn_weights, mask_value)
if torch.onnx.is_in_onnx_export():
attn_weights = torch.where(causal_mask, attn_weights.to(attn_weights.dtype), mask_value)
else:
attn_weights = torch.where(causal_mask, attn_weights, mask_value)

if attention_mask is not None:
# Apply the attention mask
Expand Down