Skip to content

Conversation

@ArthurZucker
Copy link
Collaborator

What does this PR do?

Previously the documentation was badly indented for both models and indicated that

If decoder_input_ids and decoder_inputs_embeds are both unset, decoder_inputs_embeds takes the value of inputs_embeds.Which is on valid for the forward pass of theForConditionnalGeneration` not for the model alone.

# What does this PR do?
Previously the documentation was badly indented for both models and indicated that
> If `decoder_input_ids` and `decoder_inputs_embeds` are both unset, `decoder_inputs_embeds` takes the value of `inputs_embeds`.`
Which is on valid for the forward pass of the `ForConditionnalGeneration` not for the model alone.
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 5, 2022

The documentation is not available anymore as the PR was closed or merged.

@ArthurZucker ArthurZucker requested a review from sgugger December 5, 2022 16:49
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@ArthurZucker ArthurZucker merged commit 9763f82 into huggingface:main Dec 5, 2022
@ArthurZucker ArthurZucker deleted the fix-typo branch December 5, 2022 17:23
mpierrau pushed a commit to mpierrau/transformers that referenced this pull request Dec 15, 2022
* Fix whisper and speech to text doc
# What does this PR do?
Previously the documentation was badly indented for both models and indicated that
> If `decoder_input_ids` and `decoder_inputs_embeds` are both unset, `decoder_inputs_embeds` takes the value of `inputs_embeds`.`
Which is on valid for the forward pass of the `ForConditionnalGeneration` not for the model alone.

* other fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants