[Vision] fix small nit on BeitDropPath layers
#20587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younesbelkada
changed the title
BeitDropPath layers
|
The documentation is not available anymore as the PR was closed or merged. |
NielsRogge
approved these changes
Dec 5, 2022
Contributor
NielsRogge
left a comment
NielsRogge
left a comment
There was a problem hiding this comment.
Thanks, better indeed!
ydshieh
approved these changes
Dec 5, 2022
Collaborator
ydshieh
left a comment
ydshieh
left a comment
There was a problem hiding this comment.
💯 !
BTW, I always hate this x kind variables, but this happens a lot in many many deep learning repos, especially the vision models!
mpierrau
pushed a commit
to mpierrau/transformers
that referenced
this pull request
Dec 15, 2022
* fix small nit * add last file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a small nit for
DropPathlayers pointed out in: #20550 (comment) & #20550 (comment)Preferred to fix this separately in a PR to avoid modifying too much files in #20550
cc @NielsRogge @patrickvonplaten