Skip to content

[trainer] apex test fix#20454

Merged
stas00 merged 1 commit intomainfrom
apex_fused_fix
Nov 25, 2022
Merged

[trainer] apex test fix#20454
stas00 merged 1 commit intomainfrom
apex_fused_fix

Conversation

@stas00
Copy link
Contributor

@stas00 stas00 commented Nov 25, 2022

there was a small mistake in a test of #18961, this PR fixes it.

the main CI doesn't have apex installed that's why it missed it.

Thank you, @ydshieh for the heads up about the breakage

@stas00 stas00 changed the title [AnyPrecisionAdamW] test fix [trainer] apex test fix Nov 25, 2022
@stas00 stas00 requested a review from sgugger November 25, 2022 16:23
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 25, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix!

@sgugger is off, and the fix is simple, we could merge.
It won't get worse than the current failure!

@stas00 stas00 merged commit a547d5b into main Nov 25, 2022
@stas00 stas00 deleted the apex_fused_fix branch November 25, 2022 17:02
mpierrau pushed a commit to mpierrau/transformers that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants