[Maskformer] Add MaskFormerSwin backbone #20344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
NielsRogge
force-pushed
the
add_maskformer_swin_backbone
branch
from
ac15e04 to
692be5a
Compare
sgugger
reviewed
Nov 22, 2022
Collaborator
sgugger
left a comment
sgugger
left a comment
There was a problem hiding this comment.
Thanks for working on this, it makes the code of Maskformer much cleaner!
src/transformers/models/maskformer/configuration_maskformer_swin.py
Outdated
Show resolved
Hide resolved
| super().__init__() | ||
| self.encoder = MaskFormerSwinTransformerBackbone(config.backbone_config) | ||
|
|
||
| # TODD: add method to load pretrained weights of backbone |
Collaborator
There was a problem hiding this comment.
That's not the job the init, it's more the job of from_pretrained.
added 15 commits
November 28, 2022 17:22
NielsRogge
force-pushed
the
add_maskformer_swin_backbone
branch
from
322dd71 to
8119850
Compare
NielsRogge
commented
Nov 28, 2022
sgugger
approved these changes
Nov 28, 2022
src/transformers/models/maskformer/configuration_maskformer_swin.py
Outdated
Show resolved
Hide resolved
mpierrau
pushed a commit
to mpierrau/transformers
that referenced
this pull request
Dec 15, 2022
* First draft * Fix backwards compatibility * More fixes * More fixes * Make backbone more general * Improve backbone * Improve test * Fix config checkpoint * Address comments * Use model_type * Address more comments * Fix special model names * Remove MaskFormerSwinModel and MaskFormerSwinPreTrainedModel from main init * Fix typo * Update backbone * Apply suggestion Co-authored-by: Niels Rogge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is part 2 of 3 of the big #20204 PR.
This PR adds MaskFormerSwin to the AutoBackbone API. This ensures that the model can be used as backbone with the MaskFormer framework.
As it makes more sense to move MaskFormerSwin to its own modeling files, this PR implements it in a separate
modeling_maskformer_swin.pyfile, along with a configuration implemented inconfiguration_maskformer_swin.py.To do: