-
Notifications
You must be signed in to change notification settings - Fork 31.7k
Created README_hd.md #19903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created README_hd.md #19903
Conversation
A Hindi Translation for README
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
sgugger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add the proper info in this dictionary so this translation is kept up to date when we add new models?
|
added the proper info in this dictionary By a new pull request |
|
No this should all be in the same pull request please. |
Added the Proper info for Hindi Translation of README File !
Updated the check_copies.py in this current Pull Request and closed the previous Pull Request ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @AkshitGulyan, great work 🤗. Thanks for putting in a lot of effort for making transformers accessible to an even larger number of people who are comfortable in Hindi language ✨. Looking good, left comments for improving readability.
Fixed some translation issues !
|
Any Update ? |
|
I think you need to run |
|
Please address remaining comments along with steps Sylvain has mentioned and then we are good to go |
Addressed all the comments and updated the file according to them ! |
|
Hello @AkshitGulyan, in the above PR I fixed subtle and time-consuming bugs to run
This was a subtle bug which took quite some time to figure out. You had improperly formatted the following models with improper spaces resulting in regex failing, below shows the buggy version: So, after fixing it everything works as expected: Also, model list is very very inconsistent with some models having names in Hindi while others in English. Follow the format where all model names are in latin script instead of Devanagari script. |
|
Hello @AkshitGulyan, please transfer the changes from above sample PR to this PR. Thank you and hope the above explanation clarifies the steps that Sylvain was suggesting. |
|
Hello @AkshitGulyan, can you please reopen this PR and transfer the relevant changes from above sample PR to this PR. |
A Hindi Translation for README
What does this PR do?
It adds the Hindi Translation for the README File !
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.