Revert to rescale and safely handle flag in owlvit config #18750
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
alaradirik
left a comment
alaradirik
left a comment
There was a problem hiding this comment.
Thank you! And sorry about the double PR to revert the changes
| if "rescale" in kwargs: | ||
| rescale_val = kwargs.pop("rescale") | ||
| kwargs["do_rescale"] = rescale_val | ||
|
|
There was a problem hiding this comment.
Looks good! Will we eventually remove this part?
There was a problem hiding this comment.
Yes. I think we can leave it for a short period of time so that if anyone pushes to the hub and updates the model, pushing the feature extractor with it, then the rescale parameter will be renamed in the preprocessor_config.json. After that, we could add a warning if rescale is in detected in the config - asking the person to update their config as it will no longer be supported as a flag in the future.
LysandreJik
left a comment
LysandreJik
left a comment
There was a problem hiding this comment.
Perfect! Thanks for handling the backwards compatibility @amyeroberts
5 participants
What does this PR do?
Reverts the
rescale_imagemethod name to back torescale. This keeps the method inline with other method names such asnormalize.This undoes the renaming in #18677 done to address failing tests caused by
rescalekey being in OWL-ViT config and the introduction of arescalemethod in #18499.The OWL-ViT config has since been updated. As the model has been released, we rename the key in the config in case
rescaleis there for backwards compatibility.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.