Fix torch version comparisons (helps with +cu*** or +cpu official builds)#18460
Merged
sgugger merged 1 commit intohuggingface:mainfrom Aug 3, 2022
Merged
Conversation
Comparisons like
version.parse(torch.__version__) > version.parse("1.6")
are True for torch==1.6.0+cu101 or torch==1.6.0+cpu
version.parse(version.parse(torch.__version__).base_version) are preferred (and available in pytorch_utils.py
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Aug 3, 2022
Contributor
|
Wow very cool @LSinev ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparisons like
version.parse(torch.__version__) > version.parse("1.6")are
Truefortorch==1.6.0+cu101ortorch==1.6.0+cpu(which is not intended, I suppose).So
version.parse(version.parse(torch.__version__).base_version)comparisons are preferred (and used in pytorch_utils.py but not in other places).What does this PR do?
version.parse(version.parse(torch.__version__).base_version)pytorch_utils.pyDid not check if original version checks were eligible. Believe original authors just missed this version check caveat.
Only torch version check changed (not sure if other packages may be affected).
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
As it is touching many parts of code: @patrickvonplaten, @LysandreJik, @sgugger