Skip to content

Conversation

@iedmrc
Copy link
Contributor

@iedmrc iedmrc commented Nov 14, 2019

sum() is the leanest method to flatten a string list, so it's been replaced by itertools.chain.from_iterable() . Please check #1830

@codecov-io
Copy link

codecov-io commented Nov 14, 2019

Codecov Report

Merging #1831 into master will decrease coverage by 1.36%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1831      +/-   ##
==========================================
- Coverage   84.16%   82.79%   -1.37%     
==========================================
  Files          94       94              
  Lines       14185    14186       +1     
==========================================
- Hits        11939    11746     -193     
- Misses       2246     2440     +194
Impacted Files Coverage Δ
transformers/tokenization_utils.py 91.22% <100%> (+0.02%) ⬆️
transformers/modeling_tf_pytorch_utils.py 9.85% <0%> (-83.1%) ⬇️
transformers/tests/modeling_tf_common_test.py 81.55% <0%> (-15.54%) ⬇️
transformers/modeling_roberta.py 59.41% <0%> (-12.36%) ⬇️
transformers/modeling_xlnet.py 71.18% <0%> (-2.44%) ⬇️
transformers/modeling_ctrl.py 94.24% <0%> (-2.22%) ⬇️
transformers/modeling_openai.py 80.66% <0%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 155c782...7627dde. Read the comment docs.

@LysandreJik
Copy link
Member

Looks good to me, thank you @iedmrc!

@thomwolf
Copy link
Member

Great, thanks a lot @iedmrc!

@thomwolf thomwolf merged commit 1a237d7 into huggingface:master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants