Skip to content

Add support for Sagemaker Model Parallel >= 1.10 new checkpoint API #18221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sgugger merged 3 commits into from
Jul 21, 2022
Merged

Add support for Sagemaker Model Parallel >= 1.10 new checkpoint API #18221

sgugger merged 3 commits into from
Jul 21, 2022

Conversation

@viclzhu
Copy link
Contributor

@viclzhu viclzhu commented Jul 20, 2022 •
edited
Loading

What does this PR do?

This PR adds support for Sagemaker Model Parallel >= 1.10's new checkpoint API while keeping SMP < 1.10 functionality.

  • Support loading checkpoints saved with SMP < 1.10 in SMP < 1.10 and SMP >= 1.10

  • Support loading checkpoints saved with SMP >= 1.10 in SMP >= 1.10

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

viclzhu added 3 commits July 20, 2022 12:01
@viclzhu
Add support for Sagemaker Model Parallel >= 1.10 new checkpoint API
2af2d79 
* Support loading checkpoints saved with SMP < 1.10 in SMP < 1.10 and SMP >= 1.10

* Support loading checkpoints saved with SMP >= 1.10 in SMP >= 1.10
@viclzhu
Fix bug and styling
826e3cf
@viclzhu
Update based on reviewer feedback
232bbaa
@viclzhu viclzhu mentioned this pull request Jul 20, 2022
Closed
5 tasks
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 20, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Jul 21, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a new clean PR!

@sgugger sgugger merged commit d23cf5b into huggingface:main Jul 21, 2022
This was referenced Aug 4, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sgugger sgugger sgugger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@viclzhu @HuggingFaceDocBuilderDev @sgugger