TF: remove graph mode distinction when processing boolean options #18102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gante
commented
Jul 11, 2022
| ) | ||
| final_booleans["return_dict"] = ( | ||
| kwargs["return_dict"] if kwargs["return_dict"] is not None else config.return_dict | ||
| # Pure conv models (such as ConvNext) do not have `output_attentions`. If the signature has |
Contributor
Author
There was a problem hiding this comment.
(The if branch in the old code was kept with no changes, the else was deleted)
sgugger
approved these changes
Jul 11, 2022
Collaborator
sgugger
left a comment
sgugger
left a comment
There was a problem hiding this comment.
LGTM but ultimately defers to @Rocketknight1 :-)
|
The documentation is not available anymore as the PR was closed or merged. |
Member
|
LGTM! All code of this type should be removed imo - it's an artifact of TF 1.x. Modern TF code is compiled by tracing and recompiled if Python flags are changed and can handle all kinds of weird Python flow control as a result. |
Rocketknight1
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes a very old
ifbranch related to boolean options, as TF graph mode can handle both branches with no issues -- it passes core tests for the models I tried.It also unblocks @sayakpaul in the demo he's building for the TF SegFormer (#17910), which requires setting
output_hidden_statesin graph mode.