Skip to content

Conversation

@darthvader2
Copy link
Contributor

  • Added command for activating virtual environment on windows machine in Installation docs ( @sgugger )

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 4, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this guide better! I left a small comment.

```bash
source .env/bin/activate
```
Activate Virtual environment on Windows
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should specify on the previous block (line 37) that it's for Linux and MacOs. All in all something like this:

Activate the virtual environment. On Linux and MacOs:
```bash
source .env/bin/activate
```
On Windows:
```bash
source .env/bin/activate
```

@darthvader2
Copy link
Contributor Author

Thank you @sgugger and @LysandreJik ! I have made the changes as per your comments

@sgugger sgugger merged commit 91c4a3a into huggingface:main Jul 7, 2022
@sgugger
Copy link
Collaborator

sgugger commented Jul 7, 2022

Thanks a lot!

viclzhu pushed a commit to viclzhu/transformers that referenced this pull request Jul 18, 2022
…ngface#18008)

* Added command for windows VENV activation

* changed linux and macos  specification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants