Replace BloomTokenizer by BloomTokenizerFast in doc#18005
Merged
sgugger merged 1 commit intohuggingface:mainfrom Jul 4, 2022
regisss:bloom_tokenizer
Merged
Replace BloomTokenizer by BloomTokenizerFast in doc#18005sgugger merged 1 commit intohuggingface:mainfrom regisss:bloom_tokenizer
sgugger merged 1 commit intohuggingface:mainfrom
regisss:bloom_tokenizer
Conversation
younesbelkada
approved these changes
Jul 4, 2022
Contributor
younesbelkada
left a comment
There was a problem hiding this comment.
LGTM thanks for spotting this ! 🚀
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
Author
|
CI passed, pinging @sgugger for final approval |
4 tasks
viclzhu
pushed a commit
to viclzhu/transformers
that referenced
this pull request
Jul 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The current documentation examples for BLOOM propose to import its tokenizer as follows:
from transformers import BloomTokenizer. This returns the following error with version 4.20.1:because
BloomTokenizeris actually not defined anywhere. This PR replaces it in the doc byBloomTokenizerFast.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.