Restore original task in test_warning_logs#17985
Merged
ydshieh merged 2 commits intohuggingface:mainfrom Jul 1, 2022
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
aarnphm
approved these changes
Jul 1, 2022
Contributor
aarnphm
left a comment
aarnphm
left a comment
There was a problem hiding this comment.
nice catch. cc @sgugger @LysandreJik
sgugger
approved these changes
Jul 1, 2022
Comment on lines
788
to
789
| # restore | ||
| PIPELINE_REGISTRY.register_pipeline(alias, original_task) |
Collaborator
There was a problem hiding this comment.
This should be done in a finally after a try for the rest, so it doesn't mess other tests when it fails.
Collaborator
Author
There was a problem hiding this comment.
It is the last statement in test_warning_logs. By the rest, what do you mean?
Collaborator
Author
There was a problem hiding this comment.
Oh, I guess I understand. Let me try
Contributor
There was a problem hiding this comment.
so it would be
try:
with ...
finally:
PIPELINE_REGISTRY.register_pipeline(alias, original_task)
ydshieh
commented
Jul 1, 2022
| self.assertIn(f"{alias} is already registered", cm.out) | ||
| finally: | ||
| # restore | ||
| PIPELINE_REGISTRY.register_pipeline(alias, original_task) |
viclzhu
pushed a commit
to viclzhu/transformers
that referenced
this pull request
Jul 18, 2022
Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
test_warning_logsmodifiesPIPELINE_REGISTRYviaPIPELINE_REGISTRY.register_pipeline(alias, {}), which fails the tests inTextClassificationPipelineTests.This PR restores the original task at the end of
test_warning_logs.cc @aarnphm