-
Notifications
You must be signed in to change notification settings - Fork 32k
Add ONNX support for LayoutLMv3 #17953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
022cea8
Add ONNX support for LayoutLMv3
regisss e34e5ce
Merge branch 'main' into layoutlmv3_onnx
regisss e32dc24
Update docstrings
regisss 771c85c
Update empty description in docstring
regisss b1f1a00
Merge branch 'main' into layoutlmv3_onnx
regisss fdc9d98
Fix imports and type hints
regisss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,6 +40,7 @@ | |
|
|
||
| if TYPE_CHECKING: | ||
| from ..feature_extraction_utils import FeatureExtractionMixin | ||
| from ..processing_utils import ProcessorMixin | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice use of the type checks! |
||
| from ..tokenization_utils import PreTrainedTokenizer | ||
|
|
||
|
|
||
|
|
@@ -80,7 +81,7 @@ def check_onnxruntime_requirements(minimum_version: Version): | |
|
|
||
|
|
||
| def export_pytorch( | ||
| preprocessor: Union["PreTrainedTokenizer", "FeatureExtractionMixin"], | ||
| preprocessor: Union["PreTrainedTokenizer", "FeatureExtractionMixin", "ProcessorMixin"], | ||
| model: "PreTrainedModel", | ||
| config: OnnxConfig, | ||
| opset: int, | ||
|
|
@@ -92,7 +93,7 @@ def export_pytorch( | |
| Export a PyTorch model to an ONNX Intermediate Representation (IR) | ||
|
|
||
| Args: | ||
| preprocessor: ([`PreTrainedTokenizer`] or [`FeatureExtractionMixin`]): | ||
| preprocessor: ([`PreTrainedTokenizer`], [`FeatureExtractionMixin`] or [`ProcessorMixin`]): | ||
| The preprocessor used for encoding the data. | ||
| model ([`PreTrainedModel`]): | ||
| The model to export. | ||
|
|
@@ -269,7 +270,7 @@ def export_tensorflow( | |
|
|
||
|
|
||
| def export( | ||
| preprocessor: Union["PreTrainedTokenizer", "FeatureExtractionMixin"], | ||
| preprocessor: Union["PreTrainedTokenizer", "FeatureExtractionMixin", "ProcessorMixin"], | ||
| model: Union["PreTrainedModel", "TFPreTrainedModel"], | ||
| config: OnnxConfig, | ||
| opset: int, | ||
|
|
@@ -281,7 +282,7 @@ def export( | |
| Export a Pytorch or TensorFlow model to an ONNX Intermediate Representation (IR) | ||
|
|
||
| Args: | ||
| preprocessor: ([`PreTrainedTokenizer`] or [`FeatureExtractionMixin`]): | ||
| preprocessor: ([`PreTrainedTokenizer`], [`FeatureExtractionMixin`] or [`ProcessorMixin`]): | ||
| The preprocessor used for encoding the data. | ||
| model ([`PreTrainedModel`] or [`TFPreTrainedModel`]): | ||
| The model to export. | ||
|
|
@@ -339,7 +340,7 @@ def export( | |
|
|
||
| def validate_model_outputs( | ||
| config: OnnxConfig, | ||
| preprocessor: Union["PreTrainedTokenizer", "FeatureExtractionMixin"], | ||
| preprocessor: Union["PreTrainedTokenizer", "FeatureExtractionMixin", "ProcessorMixin"], | ||
| reference_model: Union["PreTrainedModel", "TFPreTrainedModel"], | ||
| onnx_model: Path, | ||
| onnx_named_outputs: List[str], | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unfortunate, but we probably can't change it due to backwards compatibility.
cc @LysandreJik
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we could add a deprecation warning to notify users that the order of arguments will change in v5? (Or is that type of breaking change too extreme?)