Skip to content

Conversation

@WissamAntoun
Copy link
Contributor

What does this PR do?

Fixes an issue (caused by a typo) that occurs when attempting to create TF Deberta models (v1 and v2) where the embedding_size and hidden_size are different.

here is a link to a colab demo that highlights the issue and checks if it was fixed. https://colab.research.google.com/drive/1dScSEBeaBnvgV9504MG0OKUokeDVgBia?usp=sharing

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?
    No test was needed

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 29, 2022

The documentation is not available anymore as the PR was closed or merged.

@WissamAntoun
Copy link
Contributor Author

Can you review and approve this PR ? @sgugger @LysandreJik
Thank you

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me, thanks a lot for fixing! Quick ping to @gante and/or @Rocketknight1 to confirm this is the right fix.

Copy link
Contributor

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct, bias is not and argument of tf.keras.layers.Dense (use_bias is) -- merging 👍

thanks for the fix, @WissamAntoun

@gante gante merged commit 3a064bd into huggingface:main Jul 1, 2022
@WissamAntoun WissamAntoun deleted the deberta-emb-bug-fix branch July 4, 2022 22:15
viclzhu pushed a commit to viclzhu/transformers that referenced this pull request Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants