Skip to content

Pin black to 22.3.0 to benefit from a stable --preview flag#17918

Merged
LysandreJik merged 1 commit intomainfrom
pin-black-22.3
Jun 28, 2022
Merged

Pin black to 22.3.0 to benefit from a stable --preview flag#17918
LysandreJik merged 1 commit intomainfrom
pin-black-22.3

Conversation

@LysandreJik
Copy link
Member

Pins black to 22.3.0 in order to benefit from the --preview flag continuously. This flag adds reformats for strings, exceptions, logs, and others.

The recent black 22.6.0 version's --preview flag isn't compatible with the 22.3.0 and results in line changes.

This PR pins 22.3.0 as it was deemed the path with the least friction.

@LysandreJik LysandreJik requested review from sgugger and ydshieh June 28, 2022 08:27
@LysandreJik LysandreJik marked this pull request as ready for review June 28, 2022 08:27
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the style!

@LysandreJik
Copy link
Member Author

Merging now as the code quality passes so that as few PRs are impacted as possible.

@LysandreJik LysandreJik merged commit 1dfa03f into main Jun 28, 2022
@LysandreJik LysandreJik deleted the pin-black-22.3 branch June 28, 2022 08:32
@LysandreJik LysandreJik mentioned this pull request Jun 28, 2022
9 tasks
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 28, 2022

The documentation is not available anymore as the PR was closed or merged.

@sgugger
Copy link
Collaborator

sgugger commented Jun 28, 2022

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants