Skip to content

Fix #17893, removed dead code #17917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sgugger merged 3 commits into from
Jun 29, 2022
Merged

Fix #17893, removed dead code #17917

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eefc3ba
Removed dead position_id code, fix #17893
clefourrier Jun 28, 2022
517ea68
Removed unused var
clefourrier Jun 28, 2022
db20ebf
Now ignores removed (dead) dict key for backward comp
clefourrier Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions src/transformers/models/longformer/modeling_longformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,8 +447,6 @@ def __init__(self, config):
self.LayerNorm = nn.LayerNorm(config.hidden_size, eps=config.layer_norm_eps)
self.dropout = nn.Dropout(config.hidden_dropout_prob)

# position_ids (1, len position emb) is contiguous in memory and exported when serialized
self.register_buffer("position_ids", torch.arange(config.max_position_embeddings).expand((1, -1)))
self.position_embedding_type = getattr(config, "position_embedding_type", "absolute")

self.padding_idx = config.pad_token_id
Expand All @@ -469,13 +467,8 @@ def forward(self, input_ids=None, token_type_ids=None, position_ids=None, inputs
else:
input_shape = inputs_embeds.size()[:-1]

seq_length = input_shape[1]

if position_ids is None:
position_ids = self.position_ids[:, :seq_length]

if token_type_ids is None:
token_type_ids = torch.zeros(input_shape, dtype=torch.long, device=self.position_ids.device)
token_type_ids = torch.zeros(input_shape, dtype=torch.long, device=position_ids.device)

if inputs_embeds is None:
inputs_embeds = self.word_embeddings(input_ids)
Expand Down Expand Up @@ -1392,7 +1385,7 @@ class LongformerPreTrainedModel(PreTrainedModel):
config_class = LongformerConfig
base_model_prefix = "longformer"
supports_gradient_checkpointing = True
_keys_to_ignore_on_load_missing = [r"position_ids"]
_keys_to_ignore_on_load_unexpected = [r"position_ids"]

def _init_weights(self, module):
"""Initialize the weights"""
Expand Down