BLOOM enhance alibi creation #17759
Closed
BLOOM enhance alibi creation #17759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- deals better with padded batched input - avoid useless cpu/gpu communication when creating alibi Co-authored-by: justheuristic <justheuristic@gmail.com>
|
The documentation is not available anymore as the PR was closed or merged. |
Co-authored-by: justheuristic <justheuristic@gmail.com>
sgugger
approved these changes
Jun 23, 2022
Collaborator
sgugger
left a comment
sgugger
left a comment
There was a problem hiding this comment.
Could you elaborate on what's breaking? I see the alibi tensor is created at each forward pass and is now put on the same device as the hidden_states which actually seems clean!
It doesn't break model parallelism/offload as when you call each submodule with the alibi tensor as inputs, each submodule will place it on the right device before executing the forward. I checked the corresponding tests and they all pass on this branch.
Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com>
Contributor
Author
|
Great thanks ! I think that you are right :) will merge it as soon as the lights are all green 🟢 |
Contributor
Author
|
It looks like a bad rebase happened, moved the PR at: #17866 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Thanks to @justheuristic 's contribution alibi tensor is better created/communicated during the forward pass. The tests seem to pass but still stays as an experimental feature.
cc @justheuristic
This probably will break with accelerate offloading because when initialising alibi tensor we do it only once at the beginning of the forward pass with the device of the first hidden states. In the previous version we used to dynamically change alibi's
devicewhich was fine for accelerate offloading