Refactor to inherit from nn.Module instead of nn.ModuleList#17501
Merged
LysandreJik merged 4 commits intohuggingface:mainfrom Jul 4, 2022
Merged
Refactor to inherit from nn.Module instead of nn.ModuleList#17501LysandreJik merged 4 commits intohuggingface:mainfrom
LysandreJik merged 4 commits intohuggingface:mainfrom
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Member
|
Let us know when you'd like for us to review! :) |
Blender Bot tests failing (should be unrelated to this PR) and pass locally). I don't have sufficient permisisons to re-run the CI workflow (totally or from failed)
Contributor
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
LysandreJik
approved these changes
Jul 4, 2022
Member
LysandreJik
left a comment
There was a problem hiding this comment.
Verified that both BeiT and Data2VecVision checkpoints load without trouble. Thanks for working on this, @amyeroberts!
viclzhu
pushed a commit
to viclzhu/transformers
that referenced
this pull request
Jul 18, 2022
…ace#17501) * Refactor to inherit from nn.Module instead of nn.ModuleList * Fix typo * Empty to trigger CI re-run Blender Bot tests failing (should be unrelated to this PR) and pass locally). I don't have sufficient permisisons to re-run the CI workflow (totally or from failed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors classes inheriting from
nn.ModuleListto inherit fromnn.Moduleinstead. This is to make debugging and inspecting layer outputs more easy.See also: #17493
The following was run to check the weight loading in:
Output:
Running on
mainwe see the same weights are newly initialized:Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed.