Skip to content

Fix ci_url might be None #17332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ydshieh merged 3 commits into from
May 18, 2022
Merged

Fix ci_url might be None #17332

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a87de99
fix
ydshieh May 18, 2022
2dd4246
Update utils/notification_service.py
ydshieh May 18, 2022
95dcf33
fix style
ydshieh May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions utils/notification_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,15 +741,16 @@ def add_path(self, path: str, gpu: str = None):
ci_title = os.environ.get("CI_TITLE")
ci_url = os.environ.get("CI_COMMIT_URL")

commit_number = ci_url.split("/")[-1]
ci_detail_url = f"https://api.github.com/repos/huggingface/transformers/commits/{commit_number}"
ci_details = requests.get(ci_detail_url).json()
ci_author = ci_details["author"]["login"]

if ci_title is not None:
assert ci_url is not None
ci_title = ci_title.strip().split("\n")[0].strip()

# Retrieve the PR title and author login to complete the report
commit_number = ci_url.split("/")[-1]
ci_detail_url = f"https://api.github.com/repos/huggingface/transformers/commits/{commit_number}"
ci_details = requests.get(ci_detail_url).json()
ci_author = ci_details["author"]["login"]

merged_by = None
# Find the PR number (if any) and change the url to the actual PR page.
numbers = pr_number_re.findall(ci_title)
Expand Down