Skip to content

[tests] fix copy-n-paste error #17312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stas00 merged 2 commits into from
May 18, 2022
Merged

[tests] fix copy-n-paste error #17312

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ad12e3
[tests] fix copy-n-paste error
stas00 May 17, 2022
b33e4e7
fix
stas00 May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/trainer/test_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1551,7 +1551,7 @@ def test_fp16_full_eval(self):
a = torch.ones(1000, bs) + 0.001
b = torch.ones(1000, bs) - 0.001

# 1. with mem metrics enabled
# 1. with fp16_full_eval disabled
trainer = get_regression_trainer(a=a, b=b, eval_len=eval_len, skip_memory_metrics=False)
metrics = trainer.evaluate()
del trainer
Expand All @@ -1572,7 +1572,7 @@ def test_fp16_full_eval(self):
# perfect world: fp32_eval == close to zero
self.assertLess(fp32_eval, 5_000)

# 2. with mem metrics disabled
# 2. with fp16_full_eval enabled
trainer = get_regression_trainer(a=a, b=b, eval_len=eval_len, fp16_full_eval=True, skip_memory_metrics=False)
metrics = trainer.evaluate()
fp16_init = metrics["init_mem_gpu_alloc_delta"]
Expand Down Expand Up @@ -1611,7 +1611,7 @@ def test_bf16_full_eval(self):
a = torch.ones(1000, bs) + 0.001
b = torch.ones(1000, bs) - 0.001

# 1. with mem metrics enabled
# 1. with bf16_full_eval disabled
trainer = get_regression_trainer(a=a, b=b, eval_len=eval_len, skip_memory_metrics=False)
metrics = trainer.evaluate()
del trainer
Expand All @@ -1632,7 +1632,7 @@ def test_bf16_full_eval(self):
# perfect world: fp32_eval == close to zero
self.assertLess(fp32_eval, 5_000)

# 2. with mem metrics disabled
# 2. with bf16_full_eval enabled
trainer = get_regression_trainer(a=a, b=b, eval_len=eval_len, bf16_full_eval=True, skip_memory_metrics=False)
metrics = trainer.evaluate()
bf16_init = metrics["init_mem_gpu_alloc_delta"]
Expand Down