Skip to content

Conversation

@jkmg
Copy link
Contributor

@jkmg jkmg commented Apr 25, 2022

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@jkmg
Copy link
Contributor Author

jkmg commented Apr 25, 2022

Spanish translation of the file philosophy.mdx #15947

@LysandreJik LysandreJik requested a review from omarespejel April 26, 2022 21:02
@omarespejel
Copy link
Contributor

omarespejel commented May 3, 2022

Thank you @jkmg! Could you please add philosophy to transformers/docs/source/es/_toctree.yml? As a reference, you can use the new Translation guide (section "✍️ Start translating"). This would allow the tests to pass.

@jkmg jkmg closed this May 9, 2022
@jkmg jkmg reopened this May 9, 2022
Copy link
Contributor Author

@jkmg jkmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it now OK?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 9, 2022

The documentation is not available anymore as the PR was closed or merged.

@jkmg jkmg mentioned this pull request May 10, 2022
5 tasks
@omarespejel omarespejel merged commit 36ddcc0 into huggingface:main May 12, 2022
@omarespejel
Copy link
Contributor

@jkmg Thank you very much! Merged 🤗. Please let me know, through the #15947, if you wish to translate another part of the docs.

@omarespejel omarespejel changed the title Spanish translation of the file philosophy.mdx #15947 Spanish translation of the file philosophy.mdx May 12, 2022
ArthurZucker pushed a commit to ArthurZucker/transformers that referenced this pull request May 12, 2022
…16922)

* adding philosophy.mdx translation to Spanish

* adding philosophy.mdx translation to Spanish

* Update docs/source/es/philosophy.mdx

Co-authored-by: Omar U. Espejel <[email protected]>

* Update docs/source/es/philosophy.mdx

Co-authored-by: Omar U. Espejel <[email protected]>

* Update docs/source/es/philosophy.mdx

Co-authored-by: Omar U. Espejel <[email protected]>

* Update docs/source/es/philosophy.mdx

Co-authored-by: Omar U. Espejel <[email protected]>

* Update docs/source/es/philosophy.mdx

Co-authored-by: Omar U. Espejel <[email protected]>

* Update docs/source/es/philosophy.mdx

Co-authored-by: Omar U. Espejel <[email protected]>

* Update docs/source/es/philosophy.mdx

Co-authored-by: Omar U. Espejel <[email protected]>

* Update docs/source/es/philosophy.mdx

Co-authored-by: Omar U. Espejel <[email protected]>

* Update docs/source/es/philosophy.mdx

Co-authored-by: Omar U. Espejel <[email protected]>

* Update docs/source/es/philosophy.mdx

Co-authored-by: Omar U. Espejel <[email protected]>

* philosophy translation to Spanish

* Update _toctree.yml

* Update _toctree.yml

* nits

Co-authored-by: Omar U. Espejel <[email protected]>
elusenji pushed a commit to elusenji/transformers that referenced this pull request Jun 12, 2022
…16922)

* adding philosophy.mdx translation to Spanish

* adding philosophy.mdx translation to Spanish

* Update docs/source/es/philosophy.mdx

Co-authored-by: Omar U. Espejel <[email protected]>

* Update docs/source/es/philosophy.mdx

Co-authored-by: Omar U. Espejel <[email protected]>

* Update docs/source/es/philosophy.mdx

Co-authored-by: Omar U. Espejel <[email protected]>

* Update docs/source/es/philosophy.mdx

Co-authored-by: Omar U. Espejel <[email protected]>

* Update docs/source/es/philosophy.mdx

Co-authored-by: Omar U. Espejel <[email protected]>

* Update docs/source/es/philosophy.mdx

Co-authored-by: Omar U. Espejel <[email protected]>

* Update docs/source/es/philosophy.mdx

Co-authored-by: Omar U. Espejel <[email protected]>

* Update docs/source/es/philosophy.mdx

Co-authored-by: Omar U. Espejel <[email protected]>

* Update docs/source/es/philosophy.mdx

Co-authored-by: Omar U. Espejel <[email protected]>

* Update docs/source/es/philosophy.mdx

Co-authored-by: Omar U. Espejel <[email protected]>

* philosophy translation to Spanish

* Update _toctree.yml

* Update _toctree.yml

* nits

Co-authored-by: Omar U. Espejel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants