fix _setup_devices in case where there is no torch.distributed package in build#16821
Merged
sgugger merged 2 commits intohuggingface:mainfrom Apr 18, 2022
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Apr 18, 2022
Collaborator
sgugger
left a comment
sgugger
left a comment
There was a problem hiding this comment.
Looks good, thanks for fixing! Could you paste this in training_args_sm as well (just in case)?
Contributor
Author
|
done! |
Collaborator
|
Thanks! |
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
…e in build (huggingface#16821) * fix _setup_devices in case where there is not torch.distributed * in training_args_sm.py as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
At least in some instances (e.g. conda on my m1), torch is built without distributed support enabled. This takes the form of torch.distributed.is_available() returning false and torch.distributed.is_initialized() raising an exception. In this particular method, it's enough to skip the check if it's not available.
This behavior causing this crash was added in #16487
Before submitting
This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
Did you read the contributor guideline,
Pull Request section?
Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
Did you write any new necessary tests?
I could mock this out but it seems painful and unnecessary. I can try to do it if you want.
Who can review?
Seems like @sgugger is the best reviewer here?