Partial checkpoint support for SMP#16734
Closed
cavdard wants to merge 2 commits intohuggingface:mainfrom
Closed
Conversation
5 tasks
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Contributor
|
@cavdard could you please run |
Contributor
Author
Update: Resolved by running @philschmid Having this error. Am I missing a step? |
Contributor
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
smp_save_partialandsmp_load_partial) to support partial checkpointing with SMP.smp_tensor_parallel_full_modelto apply tensor parallelism to whole model.local_state_dict()with partial checkpoint saving.smp.saveinstead oftorch.savewhen partial checkpoint saving is enabled.smp.loadinstead oftorch.loadwhen partial checkpoint loading is enabled. Reorders partial checkpoint loading to happen after wrapping of model, sincesmp.loadcan only load to a smp model.smp_gatheris causing increased memory usage on GPU0 when tensor parallelism is enabled. Switches todistributed_concatfor ddp.load_best_model_at_endsupport for SMP.Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.