Add tests for no_trainer and fix existing examples#16656
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
Author
|
CI failures were fixed by removing: if torch_device != "cuda":
testargs.append("--no_cuda")from From what I could see they were unused, so I didn't duplicate them from the transformers tests. Let me know if they should be added back in, with special behavior on those tests 😄 |
Collaborator
|
For information, here are the durations: Could the |
Contributor
Author
|
Changed checkpointing tests to be by epoch, and also not saving with swag. Here were those times locally for me: Before After |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New tests for the
no_trainerscriptsWhat does this add?
no_trainerscripts, mocking how the Transformers counterparts workno_trainerscripts, discovered while writing these tests