Skip to content

initialize the default rank set on TrainerState #16530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sgugger merged 2 commits into from
Apr 4, 2022
Merged

initialize the default rank set on TrainerState #16530

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4ab9d8
initialize the default rank set on TrainerState
andrescodas Mar 31, 2022
554a6af
fix style
andrescodas Apr 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/transformers/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,6 +489,11 @@ def __init__(
self.label_smoother = None

self.state = TrainerState()

# initialize the default rank set on TrainerState
self.state.is_local_process_zero = self.is_local_process_zero()
self.state.is_world_process_zero = self.is_world_process_zero()
Copy link
Collaborator

@sgugger sgugger Apr 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can pass those variables in the init two lines above directly.

Copy link
Contributor Author

@andrescodas andrescodas Apr 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed according to your suggestion and the output given by 'black'. Thanks


self.control = TrainerControl()
# Internal variable to count flos in each process, will be accumulated in `self.state.total_flos` then
# returned to 0 every time flos need to be logged
Expand Down